From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n1FKDuTQ094021 for ; Sun, 15 Feb 2009 14:13:56 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 696961940A8F for ; Sun, 15 Feb 2009 12:13:21 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id sepgFGN41JlQy8yZ for ; Sun, 15 Feb 2009 12:13:21 -0800 (PST) Date: Sun, 15 Feb 2009 15:13:21 -0500 From: Christoph Hellwig Subject: Re: [PATCH 11/17] xfs: merge xfs_inode_flush into xfs_fs_write_inode Message-ID: <20090215201321.GA16048@infradead.org> References: <20090126073136.384490000@bombadil.infradead.org> <20090126073202.588218000@bombadil.infradead.org> <20090215064225.GA8830@disturbed> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090215064225.GA8830@disturbed> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig , xfs@oss.sgi.com On Sun, Feb 15, 2009 at 05:42:25PM +1100, Dave Chinner wrote: > On Mon, Jan 26, 2009 at 02:31:47AM -0500, Christoph Hellwig wrote: > > Spliting the task for a VFS-induced inode flush into two functions doesn't > > make any sense, so merge the two functions dealing with it. > > I just realised that we should really be calling xfs_inode_flush() from > xfs_sync_inodes_ag() - it open codes xfs_inode_flush() and doesn't > have any of the non-blocking flush code for async flushes... Given that we'll hopefully do batched flushes driven directly from the sync code re-introducing the helper now just to rip it out again a little later doesn't seem to useful to me. And the calling conventions for xfs_inode_flush were rather odd to start with anyway. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs