From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Don't reset di_format in xfs_ifree()
Date: Tue, 17 Feb 2009 14:03:06 +1100 [thread overview]
Message-ID: <20090217030306.GC8830@disturbed> (raw)
In-Reply-To: <20090215192507.GA15360@infradead.org>
On Sun, Feb 15, 2009 at 02:25:08PM -0500, Christoph Hellwig wrote:
> On Fri, Feb 13, 2009 at 09:32:53AM +1100, Dave Chinner wrote:
> > > Yes, I agree. I just don't have the time to hunt it down. I see
> > > there's a call to xfs_idestroy_fork() in xfs_ireclaim() for directories
> > > but xfs_ireclaim() gets called after xfs_iflush() in xfs_reclaim_inode().
> >
> > I suspect it should be in xfs_inactive() if we are in local format.
> > This is what happens with the attribute fork. I think that is where
> > we need something like:
> >
> > if ((ip->i_d.di_mode & S_IFMT) == S_IFDIR &&
> > ip->i_d.di_nextents == 0)
> > xfs_idestroy_fork(ip, XFS_DATA_FORK);
>
> Why would we special case directories?
I guess we don't need to - I was thinking purely of local format
inodes....
> Btw, I can't reproduce this issue with the extent.c program and the
> invocation from the next patch. Does it need other parameters to
> reproduce?
No idea, I haven't been able to reproduce it either.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-02-17 3:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 0:26 [PATCH] Don't reset di_format in xfs_ifree() Lachlan McIlroy
2009-02-11 2:21 ` Eric Sandeen
2009-02-11 3:13 ` Lachlan McIlroy
2009-02-11 3:10 ` Eric Sandeen
2009-02-11 3:48 ` Felix Blyakher
2009-02-11 4:15 ` Lachlan McIlroy
2009-02-11 9:20 ` Dave Chinner
2009-02-12 0:59 ` Lachlan McIlroy
2009-02-12 22:32 ` Dave Chinner
2009-02-15 19:25 ` Christoph Hellwig
2009-02-17 3:03 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217030306.GC8830@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox