[patch] fix tolower issue in xfsprogs

[patch] fix tolower issue in xfsprogs

[Mike Frysinger]

[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]

the xfsprogs uses tolower() in xfs_dir2.c but doesnt include ctype.h for the 
definition
-mike

--- libxfs/xfs_dir2.c
+++ libxfs/xfs_dir2.c
@@ -22,6 +22,7 @@
  */
 
 #include <xfs.h>
+#include <ctype.h>	/* for tolower() */
 
 extern const struct xfs_nameops xfs_default_nameops;
 


[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [patch] fix tolower issue in xfsprogs

[Christoph Hellwig]

On Sun, Feb 22, 2009 at 01:55:40PM -0500, Mike Frysinger wrote:
> the xfsprogs uses tolower() in xfs_dir2.c but doesnt include ctype.h for the 
> definition

In 3.0.0 and current git <ctype.h> is include in platform_defs.h, so it
should also be around in xfs_dir2.c.

What xfsprogs tree and what glibc/gcc combination do you see this with?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [patch] fix tolower issue in xfsprogs

[Mike Frysinger]

[-- Attachment #1.1: Type: text/plain, Size: 547 bytes --]

On Monday 23 February 2009 08:31:09 Christoph Hellwig wrote:
> On Sun, Feb 22, 2009 at 01:55:40PM -0500, Mike Frysinger wrote:
> > the xfsprogs uses tolower() in xfs_dir2.c but doesnt include ctype.h for
> > the definition
>
> In 3.0.0 and current git <ctype.h> is include in platform_defs.h, so it
> should also be around in xfs_dir2.c.
>
> What xfsprogs tree and what glibc/gcc combination do you see this with?

i forward ported it from the last version.  i didnt expect it to be fixed in a 
different way ;).  so disregard.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs