* [patch] fix tolower issue in xfsprogs @ 2009-02-22 18:55 Mike Frysinger 2009-02-23 13:31 ` Christoph Hellwig 0 siblings, 1 reply; 3+ messages in thread From: Mike Frysinger @ 2009-02-22 18:55 UTC (permalink / raw) To: xfs-oss [-- Attachment #1.1: Type: text/plain, Size: 297 bytes --] the xfsprogs uses tolower() in xfs_dir2.c but doesnt include ctype.h for the definition -mike --- libxfs/xfs_dir2.c +++ libxfs/xfs_dir2.c @@ -22,6 +22,7 @@ */ #include <xfs.h> +#include <ctype.h> /* for tolower() */ extern const struct xfs_nameops xfs_default_nameops; [-- Attachment #1.2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 121 bytes --] _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] fix tolower issue in xfsprogs 2009-02-22 18:55 [patch] fix tolower issue in xfsprogs Mike Frysinger @ 2009-02-23 13:31 ` Christoph Hellwig 2009-02-23 14:43 ` Mike Frysinger 0 siblings, 1 reply; 3+ messages in thread From: Christoph Hellwig @ 2009-02-23 13:31 UTC (permalink / raw) To: Mike Frysinger; +Cc: xfs-oss On Sun, Feb 22, 2009 at 01:55:40PM -0500, Mike Frysinger wrote: > the xfsprogs uses tolower() in xfs_dir2.c but doesnt include ctype.h for the > definition In 3.0.0 and current git <ctype.h> is include in platform_defs.h, so it should also be around in xfs_dir2.c. What xfsprogs tree and what glibc/gcc combination do you see this with? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] fix tolower issue in xfsprogs 2009-02-23 13:31 ` Christoph Hellwig @ 2009-02-23 14:43 ` Mike Frysinger 0 siblings, 0 replies; 3+ messages in thread From: Mike Frysinger @ 2009-02-23 14:43 UTC (permalink / raw) To: Christoph Hellwig; +Cc: xfs-oss [-- Attachment #1.1: Type: text/plain, Size: 547 bytes --] On Monday 23 February 2009 08:31:09 Christoph Hellwig wrote: > On Sun, Feb 22, 2009 at 01:55:40PM -0500, Mike Frysinger wrote: > > the xfsprogs uses tolower() in xfs_dir2.c but doesnt include ctype.h for > > the definition > > In 3.0.0 and current git <ctype.h> is include in platform_defs.h, so it > should also be around in xfs_dir2.c. > > What xfsprogs tree and what glibc/gcc combination do you see this with? i forward ported it from the last version. i didnt expect it to be fixed in a different way ;). so disregard. -mike [-- Attachment #1.2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 121 bytes --] _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-23 14:44 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-02-22 18:55 [patch] fix tolower issue in xfsprogs Mike Frysinger 2009-02-23 13:31 ` Christoph Hellwig 2009-02-23 14:43 ` Mike Frysinger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox