From: Christoph Hellwig <hch@infradead.org>
To: Felix Blyakher <felixb@sgi.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
LKML <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com, Christoph Hellwig <hch@infradead.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Alexander Beregalov <a.beregalov@gmail.com>
Subject: Re: next-20090220: XFS: inconsistent lock state
Date: Tue, 3 Mar 2009 12:02:48 -0500 [thread overview]
Message-ID: <20090303170248.GA7036@infradead.org> (raw)
In-Reply-To: <A277CB1C-4258-42EC-B1D9-F5CAAB962B42@sgi.com>
On Tue, Mar 03, 2009 at 10:57:07AM -0600, Felix Blyakher wrote:
> if (lock_flags) {
> if (!xfs_ilock_nowait(ip, lock_flags)) {
> ASSERT(0);
> error = EAGAIN;
> goto out_destroy;
> }
> }
>
> Or just keep the BUG(); , as it shouldn't happen (we hope).
Ok, let's keep the BUG for now and I'll throw in your error undwinding
fix. Will resend the series for 2.6.29 patches after QAing them.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-03-03 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 17:52 next-20090220: XFS: inconsistent lock state Alexander Beregalov
2009-02-24 20:07 ` Christoph Hellwig
2009-03-03 16:00 ` Eric Sandeen
2009-03-03 16:57 ` Felix Blyakher
2009-03-03 17:02 ` Christoph Hellwig [this message]
2009-03-06 9:30 ` Alexander Beregalov
2009-03-03 16:45 ` Felix Blyakher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090303170248.GA7036@infradead.org \
--to=hch@infradead.org \
--cc=a.beregalov@gmail.com \
--cc=felixb@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox