Re: [patch] fix parallel build failures in xfsprogs-3.0.0

From: Andreas Gruenbacher <agruen@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	Mike Frysinger <vapier@gentoo.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [patch] fix parallel build failures in xfsprogs-3.0.0
Date: Tue, 10 Mar 2009 17:41:06 +0100	[thread overview]
Message-ID: <200903101741.07043.agruen@suse.de> (raw)
In-Reply-To: <200903081409.28808.agruen@suse.de>

On Sunday 08 March 2009 14:09:28 Andreas Gruenbacher wrote:
> On Wednesday, 4 March 2009 18:27:27 Christoph Hellwig wrote:
> > I've tried to port the patch you checked into xfsprogs (see below for
> > the diff), but it fails to build for me.  Any idea what might have
> > gone wrong?
>
> git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git is missing the
> following commit from
> ssh://master.kernel.org/pub/scm/linux/kernel/git/agruen/acl.git:
>
>   commit 8de7788c29d2656f8d52d98327a80e4dfd1e3898
>   Author: Barry Naujok <bnaujok@sgi.com>
>   Date:   Tue Jan 23 14:51:14 2007 +0000
>
>     Fix cross-compile issues with libtool and compiler.
>
>     This is equivalent to commit de7b3f6 from Barry Naujok
> <bnaujok@sgi.com> in the acl package, and part of the Gentoo package, as
> pointed out by Mike Frysinger <vapier@gentoo.org>.
>
>     Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
>
> While looking into this, I noticed that the attr and acl packages were
> calling AC_PROG_LIBTOOL both in configure.in and m4/package_utilies.m4. I
> have removed the redundant call from m4/package_utilies.m4 now.

As it turns out, I was running into more trouble with libtoolize from libtool 
2.2.6. See this commit in attr.git:

  commit 604290f79a199eb0c73a0cd05a473e1801a00673
  Author: Andreas Gruenbacher <agruen@suse.de>
  Date:   Tue Mar 10 17:00:35 2009 +0100

    More libtoolize fixes

    Recent versions of libtool behave slightly differently, which causes some
    breakage in how libtoolize was used here.  Make sure that libtoolize adds
    the auxiliary files (config.guess and config.sub).

    Move install-sh into include/ so that libtoolize does not destroy it.

    Split up the ``make clean'' and ``make distclean'' targets: the former
    removes all files generated during a build.  The latter removes all
    files generated by libtoolize, autoconf, and configure as well.

    Signed-off-by: Andreas Gruenbacher <agruen@suse.de>

With these changes, the build/*.src.tar.gz tarball should now build properly 
without depending on the version of libtool on the system with:

	./configure
	make
	make install

(The acl.git repository has the equivalent changes.)

Andreas

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs