From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n2F7ohve256690 for ; Sun, 15 Mar 2009 02:51:04 -0500 Received: from ipmail05.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7C46F199BEA for ; Sun, 15 Mar 2009 00:50:21 -0700 (PDT) Received: from ipmail05.adl2.internode.on.net (ipmail05.adl2.internode.on.net [203.16.214.145]) by cuda.sgi.com with ESMTP id qdrdXXwD4V75c1Hg for ; Sun, 15 Mar 2009 00:50:21 -0700 (PDT) Date: Sun, 15 Mar 2009 18:50:20 +1100 From: Dave Chinner Subject: Re: [PATCH 3/7] xfs: cleanup xlog_recover_do_trans Message-ID: <20090315075020.GR26138@disturbed> References: <20090220085207.663702000@bombadil.infradead.org> <20090220085229.204188000@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090220085229.204188000@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Fri, Feb 20, 2009 at 03:52:10AM -0500, Christoph Hellwig wrote: > Change the big if-elsif-else block handling the different item types > into a more natural switch, remove assignments in conditionals and > remove an out of place comment from centuries ago on IRIX. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs