Re: [PATCH 4/7] xfs: cleanup xlog_bread

Dave Chinner
2009-03-15T07:55:01Z

On Fri, Feb 20, 2009 at 03:52:11AM -0500, Christoph Hellwig wrote:
> Most callers of xlog_bread need to call xlog_align to get the actual offset.
> Consolidate that call into the main xlog_bread and provide a _xlog_bread
> for those few that don't want the actual offset.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

.....

> * nbblks should be uint, but oh well. Just want to catch that 32-bit length.
> */
> -int
> -xlog_bread(
> +STATIC int
> +_xlog_bread(
> xlog_t *log,
> xfs_daddr_t blk_no,
> int nbblks,
> @@ -137,6 +155,24 @@ xlog_bread(
> return error;
> }

xlog_bread_noalign().

Otherwise looks good. Consider it:

Reviewed-by: Dave Chinner <david@fromorbit.com>

--
Dave Chinner
david@fromorbit.com