From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] [XFS] Validate log feature fields correctly
Date: Sun, 15 Mar 2009 11:15:51 -0400 [thread overview]
Message-ID: <20090315151546.GB7145@infradead.org> (raw)
In-Reply-To: <1237116342-25701-2-git-send-email-david@fromorbit.com>
On Sun, Mar 15, 2009 at 10:25:41PM +1100, Dave Chinner wrote:
> If the large log sector size feature bit is set in the
> superblock by accident (say disk corruption), the then
> fields that are now considered valid are not checked on
> production kernels. The checks are present as ASSERT
> statements so cause a panic on a debug kernel.
>
> Change this so that the fields are validity checked if
> the feature bit is set and abort the log mount if the
> fields do not contain valid values.
>
> Reported-by: Eric Sesterhenn <snakebyte@gmx.de>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
Looks good to me, but wouldn't be easier to rad if the various sizes
in the error messages were reported decimal instead of in hex?
Reviewed-by: Christoph Hellwig <hch@lst.de>
> } /* xlog_alloc_log */
any maybe remove this comment while you're at it?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-03-15 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 11:25 [PATCH 0/2, RESEND] [XFS] a couple of fixes Dave Chinner
2009-03-15 11:25 ` [PATCH 1/2] [XFS] Validate log feature fields correctly Dave Chinner
2009-03-15 15:15 ` Christoph Hellwig [this message]
2009-03-16 10:49 ` Dave Chinner
2009-03-16 10:50 ` Christoph Hellwig
2009-03-15 11:25 ` [PATCH 2/2] [XFS] Fix double free of inode Dave Chinner
2009-03-15 15:13 ` Christoph Hellwig
2009-04-06 22:28 ` [PATCH 0/2, RESEND] [XFS] a couple of fixes Christoph Hellwig
2009-04-08 4:45 ` Felix Blyakher
2009-04-08 13:33 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2009-03-15 10:52 [PATCH 0/2] " Dave Chinner
2009-03-15 10:52 ` [PATCH 1/2] [XFS] Validate log feature fields correctly Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090315151546.GB7145@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox