From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] [XFSQA] Test writing to ENOSPC
Date: Mon, 16 Mar 2009 02:27:06 -0400 [thread overview]
Message-ID: <20090316062706.GC30641@infradead.org> (raw)
In-Reply-To: <1237114181-18431-4-git-send-email-david@fromorbit.com>
On Sun, Mar 15, 2009 at 09:49:41PM +1100, Dave Chinner wrote:
> Use larger files and different writing styles to fill
> a 100MB filesystem to being full. In each case we should
> get very close to the filesystem being full before getting
> ENOSPC. THis tests different types of ENOSPC failures to
> test 203 and requires more changes to pass.
Looks good. But don't we actually need a trap handler to unmount the
scratch partitions if the test gets intterupted? I always added them
to my tests, copying that fragment from older patches. (also applies
to the previous patch)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-03-16 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 10:49 [PATCH 0/3] [XFSQA] Optimisations and ENOSPC tests Dave Chinner
2009-03-15 10:49 ` [PATCH 1/3] [XFSQA] Reduce the number of processes forked Dave Chinner
2009-03-16 6:23 ` Christoph Hellwig
2009-03-15 10:49 ` [PATCH 2/3] [XFSQA] Add simple delayed allocation ENOSPC test Dave Chinner
2009-03-16 6:23 ` Christoph Hellwig
2009-03-15 10:49 ` [PATCH 3/3] [XFSQA] Test writing to ENOSPC Dave Chinner
2009-03-16 6:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316062706.GC30641@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox