From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: mpatocka@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH 5/5] [XFS] Remove xfs_flush_space
Date: Mon, 16 Mar 2009 05:15:19 -0400 [thread overview]
Message-ID: <20090316091513.GE2636@infradead.org> (raw)
In-Reply-To: <1237116707-25793-6-git-send-email-david@fromorbit.com>
On Sun, Mar 15, 2009 at 10:31:47PM +1100, Dave Chinner wrote:
> The only thing we need to do now when we get an ENOSPC condition during delayed
> allocation reservation is flush all the other inodes with delalloc blocks on
> them and retry without EOF preallocation. Remove the unneeded mess that is
> xfs_flush_space() and just call xfs_flush_inodes() directly from
> xfs_iomap_write_delay().
>
> Also, change the location of the retry label to avoid trying to do EOF
> preallocation because we don't want to do that at ENOSPC. This enables us to
> remove the BMAPI_SYNC flag as it is no longer used.
Looks good.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-03-16 9:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 11:31 [PATCH 0/5, RESEND] [XFS] Spurious ENOSPC fixes Dave Chinner
2009-03-15 11:31 ` [PATCH 1/5] [XFS] Use xfs_sync_inodes() for device flushing Dave Chinner
2009-03-16 9:08 ` Christoph Hellwig
2009-03-16 10:45 ` Dave Chinner
2009-03-15 11:31 ` [PATCH 2/5] [XFS] Make inode flush at ENOSPC synchronous Dave Chinner
2009-03-16 9:12 ` Christoph Hellwig
2009-03-16 10:46 ` Dave Chinner
2009-03-15 11:31 ` [PATCH 3/5] [XFS] Block callers of xfs_flush_inodes() correctly Dave Chinner
2009-03-16 9:13 ` Christoph Hellwig
2009-03-16 10:27 ` Dave Chinner
2009-03-17 13:15 ` Mikulas Patocka
2009-03-15 11:31 ` [PATCH 4/5] [XFS] Flush delayed allcoation blocks on ENOSPC in create Dave Chinner
2009-03-16 9:14 ` Christoph Hellwig
2009-03-15 11:31 ` [PATCH 5/5] [XFS] Remove xfs_flush_space Dave Chinner
2009-03-16 9:15 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-15 10:57 [PATCH 0/5] [XFS] Spurious ENOSPC fixes Dave Chinner
2009-03-15 10:57 ` [PATCH 5/5] [XFS] Remove xfs_flush_space Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316091513.GE2636@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=mpatocka@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox