Re: [PATCH 5/5] [XFS] Remove xfs_flush_space

Christoph Hellwig
2009-03-16T09:16:01Z

On Sun, Mar 15, 2009 at 10:31:47PM +1100, Dave Chinner wrote:
> The only thing we need to do now when we get an ENOSPC condition during delayed
> allocation reservation is flush all the other inodes with delalloc blocks on
> them and retry without EOF preallocation. Remove the unneeded mess that is
> xfs_flush_space() and just call xfs_flush_inodes() directly from
> xfs_iomap_write_delay().
>
> Also, change the location of the retry label to avoid trying to do EOF
> preallocation because we don't want to do that at ENOSPC. This enables us to
> remove the BMAPI_SYNC flag as it is no longer used.

Looks good.