From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] XFS: Prevent unwritten extent conversion from blocking I/O completion
Date: Mon, 16 Mar 2009 21:37:53 +1100 [thread overview]
Message-ID: <20090316103753.GG26138@disturbed> (raw)
In-Reply-To: <20090316092124.GA21496@infradead.org>
On Mon, Mar 16, 2009 at 05:21:24AM -0400, Christoph Hellwig wrote:
> On Sun, Mar 15, 2009 at 10:40:42PM +1100, Dave Chinner wrote:
> > Unwritten extent conversion can recurse back into the filesystem due
> > to memory allocation. Memory reclaim requires I/O completions to be
> > processed to allow the callers to make progress. If the I/O
> > completion workqueue thread is doing the recursion, then we have a
> > deadlock situation.
> >
> > Move unwritten extent completion into it's own workqueue so it
> > doesn't block I/O completions for normal delayed allocation or
> > overwrite data.
>
> Hmm. That was the original reason behind splitting the data from
> xfsbufd queue. So maybe the split should be just unwritten vs the
> rest and three queues?
>
> Btw, do you have a testcase that can reproduce this?
No, I hit it a couple of times running xfsqa on a low memory UML
image - 256MB of RAM, IIRC - during one of the fstress tests. I got
enough information to determine this was the problem and it hasn't
showed up since. I think someone also posted a lockdep trace
on LKML a couple of months back as well...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-03-16 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 11:40 [PATCH 0/2] Fix a couple of random hangs Dave Chinner
2009-03-15 11:40 ` [PATCH 1/2] XFS: Prevent unwritten extent conversion from blocking I/O completion Dave Chinner
2009-03-16 9:21 ` Christoph Hellwig
2009-03-16 10:37 ` Dave Chinner [this message]
2009-03-15 11:40 ` [PATCH 2/2] XFS: Inform the xfsaild of the push target before sleeping Dave Chinner
2009-03-16 10:38 ` Christoph Hellwig
2009-03-16 11:00 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316103753.GG26138@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox