From: Christoph Hellwig <hch@infradead.org>
To: Felix Blyakher <felixb@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix async io error handling in fsx
Date: Mon, 13 Apr 2009 09:58:34 -0400 [thread overview]
Message-ID: <20090413135834.GA3196@infradead.org> (raw)
In-Reply-To: <20090406163331.GA22240@infradead.org>
On Mon, Apr 06, 2009 at 12:33:31PM -0400, Christoph Hellwig wrote:
> On Mon, Apr 06, 2009 at 10:26:16AM -0500, Felix Blyakher wrote:
> > The result of async io returned in the event.res in addition
> > to the number of bytes read/written provides negated error
> > number. The broken libaio defines event.res as unsigned
> > while the same structure in the kernel defines it as signed.
> > The kernel indeed treats it as signed, and returns the
> > negated error number. Till libaio is fixed we provide
> > the signed long temp var.
> > Also set errno for each error condition in aio_rw, as the
> > caller is not aio aware and expects ret(-1)+errno by the
> > traditional libc convention.
>
> Looks good.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Do you plan to commit this? Otherwise I'll just suck it into the
xfstests-dev tree.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-04-13 13:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 15:26 [PATCH] xfstests: fix async io error handling in fsx Felix Blyakher
2009-04-06 16:33 ` Christoph Hellwig
2009-04-13 13:58 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-30 19:41 Felix Blyakher
2009-04-01 7:21 ` Christoph Hellwig
2009-03-30 5:30 Felix Blyakher
2009-03-30 17:54 ` Christoph Hellwig
2009-03-30 18:53 ` Felix Blyakher
2009-03-30 18:56 ` Christoph Hellwig
2009-03-30 18:59 ` Felix Blyakher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413135834.GA3196@infradead.org \
--to=hch@infradead.org \
--cc=felixb@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox