From: "Josef 'Jeff' Sipek" <jeffpc@josefsipek.net>
To: Felix Blyakher <felixb@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: add more checks to superblock validation
Date: Sun, 19 Apr 2009 14:14:10 -0400 [thread overview]
Message-ID: <20090419181410.GS3709@josefsipek.net> (raw)
In-Reply-To: <81FBAD0F-AE2A-4780-BC8B-135C4CCE8D3A@sgi.com>
On Sun, Apr 19, 2009 at 11:39:20AM -0500, Felix Blyakher wrote:
>
> On Apr 18, 2009, at 12:05 AM, Josef 'Jeff' Sipek wrote:
>
>> On Fri, Apr 17, 2009 at 04:12:45PM -0500, Felix Blyakher wrote:
>>> From: Olaf Weber <olaf@sgi.com>
>>>
>>> There had been reports where xfs filesystem was randomly
>>> corrupted with fsfuzzer, and xfs failed to handle it
>>> gracefully. This patch fixes couple of reported problem
>>> by providing additional checks in the superblock
>>> validation routine.
>>>
>>> Signed-off-by: Felix Blyakher <felixb@sgi.com>
>>
>> Since this patch is from Olaf, shouldn't he have a s-o-b line as well?
>
> I was following the guidelines from the SubmittingPatches:
>
> The "from" line must be the very first line in the message body,
> and has the form:
>
> From: Original Author <author@example.com>
>
> The "from" line specifies who will be credited as the author of the
> patch in the permanent changelog. If the "from" line is missing,
> then the "From:" line from the email header will be used to determine
> the patch author in the changelog.
>
>
> So, is "From:" enough here, or "Signed-off-by" is needed as well?
The From line determines author-ship. If this is Olaf's patch, then the From
is right. My understanding is that s-o-b is intended as a "I didn't do
anything stupid (e.g., incorporate licensed code, etc.) while working on
this patch/handling this patch." This makes me believe that the author
should include a s-o-b line as well.
So, for example, whenever _I_ send a patch that I authored, I have both a
>From and a s-o-b. If someone picks it up (e.g., akpm), he'd add his s-o-b,
so when he resends it, it'd have my from, my s-o-b, and his s-o-b. As far as
I know, other kernel folks do the same.
Jeff.
--
My public GPG key can be found at
http://www.josefsipek.net/gpg/public-0xC7958FFE.txt
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-04-19 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 21:12 [PATCH] xfs: add more checks to superblock validation Felix Blyakher
2009-04-18 5:05 ` Josef 'Jeff' Sipek
2009-04-19 16:39 ` Felix Blyakher
2009-04-19 18:14 ` Josef 'Jeff' Sipek [this message]
2009-04-21 15:47 ` Felix Blyakher
2009-04-21 16:52 ` Josef 'Jeff' Sipek
2009-04-19 21:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090419181410.GS3709@josefsipek.net \
--to=jeffpc@josefsipek.net \
--cc=felixb@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox