[PATCH] make lazy-count=1 the default

[PATCH] make lazy-count=1 the default

[Eric Sandeen]

If folks think it's been out there long enough, let's make
lazy-count=1 the mkfs default going forward?

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

Index: xfsprogs-2.10.2/mkfs/xfs_mkfs.c
===================================================================
--- xfsprogs-2.10.2.orig/mkfs/xfs_mkfs.c
+++ xfsprogs-2.10.2/mkfs/xfs_mkfs.c
@@ -733,7 +733,7 @@ main(
 	nodsflag = norsflag = 0;
 	force_overwrite = 0;
 	worst_freelist = 0;
-	lazy_sb_counters = 0;
+	lazy_sb_counters = 1;
 	memset(&fsx, 0, sizeof(fsx));
 
 	memset(&xi, 0, sizeof(xi));
Index: xfsprogs-2.10.2/man/man8/mkfs.xfs.8
===================================================================
--- xfsprogs-2.10.2.orig/man/man8/mkfs.xfs.8
+++ xfsprogs-2.10.2/man/man8/mkfs.xfs.8
@@ -455,9 +455,10 @@ counter values without needed to keep th
 This gives significant improvements in performance on some configurations.
 The default
 .I value
-is 0 (off) so you must specify
-.B lazy-count=1
-if you want to make use of this feature.
+is 1 (on) so you must specify
+.B lazy-count=0
+if you want to disable this feature for older kernels which don't support
+it.
 .RE
 .TP
 .BI \-n " naming_options"

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] make lazy-count=1 the default

[Josef 'Jeff' Sipek]

On Tue, Apr 21, 2009 at 04:47:09PM -0500, Eric Sandeen wrote:
> If folks think it's been out there long enough, let's make
> lazy-count=1 the mkfs default going forward?
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Sounds good!

It may be worth mentioning the kernel version that introduced lazy-count in
the manpage.

Josef 'Jeff' Sipek.

-- 
It used to be said [...] that AIX looks like one space alien discovered
Unix, and described it to another different space alien who then implemented
AIX. But their universal translators were broken and they'd had to gesture a
lot.
		- Paul Tomblin 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] make lazy-count=1 the default

[Christoph Hellwig]

On Tue, Apr 21, 2009 at 04:47:09PM -0500, Eric Sandeen wrote:
> If folks think it's been out there long enough, let's make
> lazy-count=1 the mkfs default going forward?

Yes, please put it in just after the 3.0.1 release we'll hopefully
put out ASAP.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs