public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfstests: fix 130, 132 for inifinitely-fast disks
@ 2009-04-23 18:29 Eric Sandeen
  2009-04-24  6:01 ` Josef 'Jeff' Sipek
  2009-04-24 17:51 ` Christoph Hellwig
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2009-04-23 18:29 UTC (permalink / raw)
  To: xfs mailing list

Due to the new quantum/holographic storage I'm testing, my 
disks go infinitely fast, thereby breaking some filters:

-XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+3 KiB, 1 ops; 0.0000 sec (inf EiB/sec and inf ops/sec)

I'm no regexp expert but I think the below change will fix it.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/130 b/130
index f287d20..b0bbe73 100755
--- a/130
+++ b/130
@@ -51,7 +51,7 @@ common_line_filter()
 
 _filter_xfs_io()
 {
-    common_line_filter | sed -e "s/[0-9/.]* [GMKiBbytes]*, [0-9]* ops\; [0-9/:. sec]* ([0-9/.]* [GMKiBbytes]*\/sec and [0-9/.]* ops\/sec)/XXX Bytes, X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/"
+    common_line_filter | sed -e "s/[0-9/.]* [GMKiBbytes]*, [0-9]* ops\; [0-9/:. sec]* ([inf0-9/.]* [EPGMKiBbytes]*\/sec and [inf0-9/.]* ops\/sec)/XXX Bytes, X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/"
 }
 
 # real QA test starts here
diff --git a/132 b/132
index df3d3d3..f373256 100755
--- a/132
+++ b/132
@@ -43,7 +43,7 @@ common_line_filter()
 
 _filter_xfs_io()
 {
-    common_line_filter | sed -e "s/[0-9/.]* [GMKiBbytes]*, [0-9]* ops\; [0-9/:. sec]* ([0-9/.]* [GMKiBbytes]*\/sec and [0-9/.]* ops\/sec)/XXX Bytes, X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/"
+    common_line_filter | sed -e "s/[0-9/.]* [GMKiBbytes]*, [0-9]* ops\; [0-9/:. sec]* ([inf0-9/.]* [EPGMKiBbytes]*\/sec and [inf0-9/.]* ops\/sec)/XXX Bytes, X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/"
 }
 
 # real QA test starts here

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfstests: fix 130, 132 for inifinitely-fast disks
  2009-04-23 18:29 [PATCH] xfstests: fix 130, 132 for inifinitely-fast disks Eric Sandeen
@ 2009-04-24  6:01 ` Josef 'Jeff' Sipek
  2009-04-24 17:51 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Josef 'Jeff' Sipek @ 2009-04-24  6:01 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs mailing list

On Thu, Apr 23, 2009 at 01:29:13PM -0500, Eric Sandeen wrote:
> Due to the new quantum/holographic storage I'm testing, my 
> disks go infinitely fast, thereby breaking some filters:

If you want, send me those drives, and I'll test them for you ;)

> -XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +3 KiB, 1 ops; 0.0000 sec (inf EiB/sec and inf ops/sec)
> 
> I'm no regexp expert but I think the below change will fix it.
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Yep, that'll do it.

Josef 'Jeff' Sipek.

-- 
What is the difference between Mechanical Engineers and Civil Engineers?
Mechanical Engineers build weapons, Civil Engineers build targets.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfstests: fix 130, 132 for inifinitely-fast disks
  2009-04-23 18:29 [PATCH] xfstests: fix 130, 132 for inifinitely-fast disks Eric Sandeen
  2009-04-24  6:01 ` Josef 'Jeff' Sipek
@ 2009-04-24 17:51 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2009-04-24 17:51 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs mailing list

On Thu, Apr 23, 2009 at 01:29:13PM -0500, Eric Sandeen wrote:
> Due to the new quantum/holographic storage I'm testing, my 
> disks go infinitely fast, thereby breaking some filters:
> 
> -XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +3 KiB, 1 ops; 0.0000 sec (inf EiB/sec and inf ops/sec)
> 
> I'm no regexp expert but I think the below change will fix it.

Looks good to me.  I used to see this too when running xfsqa under qemu
(with really fast disk (=host pagecache) and a really slow cpu..

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-04-24 17:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-23 18:29 [PATCH] xfstests: fix 130, 132 for inifinitely-fast disks Eric Sandeen
2009-04-24  6:01 ` Josef 'Jeff' Sipek
2009-04-24 17:51 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox