From: Christoph Hellwig <hch@infradead.org>
To: Felix Blyakher <felixb@sgi.com>
Cc: kernel-testers@vger.kernel.org, linux-kernel@vger.kernel.org,
a.beregalov@gmail.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix double unlock in xfs_swap_extents()
Date: Fri, 8 May 2009 02:28:19 -0400 [thread overview]
Message-ID: <20090508062819.GB1689@infradead.org> (raw)
In-Reply-To: <1241745202-7452-1-git-send-email-felixb@sgi.com>
The patch looks good, but a little nitpick:
On Thu, May 07, 2009 at 08:13:22PM -0500, Felix Blyakher wrote:
> out:
> kmem_free(tempifp);
> return error;
>
> +out_unlock:
> + xfs_iunlock(ip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
> + xfs_iunlock(tip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
> + goto out;
> +
> out_trans_cancel:
> xfs_trans_cancel(tp, 0);
> goto out_unlock;
this would be more readable as:
out_trans_cancel:
xfs_trans_cancel(tp, 0);
out_unlock:
xfs_iunlock(ip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
xfs_iunlock(tip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
goto out;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-05-08 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 1:13 [PATCH] xfs: fix double unlock in xfs_swap_extents() Felix Blyakher
2009-05-08 2:57 ` Eric Sandeen
2009-05-08 5:20 ` Felix Blyakher
2009-05-08 6:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090508062819.GB1689@infradead.org \
--to=hch@infradead.org \
--cc=a.beregalov@gmail.com \
--cc=felixb@sgi.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox