From: Christoph Hellwig <hch@infradead.org>
To: Ray Lee <ray-lk@madrabbit.org>
Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org,
Anton Salikhmetov <salikhmetov@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ferenc Wagner <wferi@niif.hu>
Subject: Re: mmap vs mtime in 2.6.26 and up
Date: Tue, 12 May 2009 11:53:01 -0400 [thread overview]
Message-ID: <20090512155301.GA23160@infradead.org> (raw)
In-Reply-To: <2c0942db0905120837g702b457bm52a412293925021a@mail.gmail.com>
On Tue, May 12, 2009 at 08:37:43AM -0700, Ray Lee wrote:
> > I've noticed that the last modification times of our RRD files got
> > stuck after upgrading from 2.6.24 to 2.6.26 (Debian Etch -> Lenny; I
> > also tested with 2.6.30-rc5, they are still stuck). ??It has some
> > literature, most notably kernel bug #2645, but that's closed long ago
> > and the resulting patch http://lkml.org/lkml/2008/1/22/370 is present
> > in my kernels. ??Still, the test program (version 3 from the bug report)
> > gives failures:
The problem is pretty simple. do_wp_page and __do_fault use
file_update_time to update ctime and mtime. But this function is only
a helper for simply filesystems that have a binary inode dirty/non dirty
state and keep the m/ctime purely in the Linux inode. It must not be
called from generic code as more complex filesystems need a notification
through ->setattr to update the timestamps. This will also affect other
filesystems like ubifs. I'm not entirely sure why it ever worked
before, we must have picked up those c/mtime updates by accident
somehow.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-05-12 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <874ovws94s.fsf@tac.ki.iif.hu>
[not found] ` <87ljp2v6vt.fsf@tac.ki.iif.hu>
2009-05-12 15:37 ` mmap vs mtime in 2.6.26 and up Ray Lee
2009-05-12 15:53 ` Christoph Hellwig [this message]
2009-05-15 16:40 ` Ferenc Wagner
2009-05-15 16:50 ` Christoph Hellwig
2009-05-18 11:43 ` Christoph Hellwig
2009-07-22 17:52 ` Ferenc Wagner
2009-09-25 12:47 ` Ferenc Wagner
2009-09-26 13:10 ` Christoph Hellwig
2009-10-15 0:08 ` Ferenc Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512155301.GA23160@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ray-lk@madrabbit.org \
--cc=salikhmetov@gmail.com \
--cc=wferi@niif.hu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox