From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n4GKeGXM140979 for ; Sat, 16 May 2009 15:40:17 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id CC7C828ECBC for ; Sat, 16 May 2009 13:40:25 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id SEI8VY8mSOs23Crb for ; Sat, 16 May 2009 13:40:25 -0700 (PDT) Date: Sat, 16 May 2009 16:40:25 -0400 From: Christoph Hellwig Subject: Re: [PATCH] xfsprogs: add fallocate command to xfs_io Message-ID: <20090516204025.GC28186@infradead.org> References: <4A077195.3070708@sandeen.net> <20090515171324.GA14804@infradead.org> <20090515172711.GA23630@infradead.org> <4A0DB97F.4020201@sandeen.net> <4A0DE88C.2040401@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4A0DE88C.2040401@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: Christoph Hellwig , xfs-oss On Fri, May 15, 2009 at 05:11:24PM -0500, Eric Sandeen wrote: > Instead of above does this work better? > > (just change AC_TRY_COMPILE to AC_TRY_LINK) Yes, that correctly detects fallocate as not present for me and thus gives a working fallocate. > > AC_DEFUN([AC_HAVE_FALLOCATE], > [ AC_MSG_CHECKING([for fallocate]) > AC_TRY_LINK([ > #include > ], [ > fallocate(0, 0, 0, 0); Why do you nee to include here anyway? You don't use any of the constants, and the fallocate libc call must be in another headers, so it obviously compiles even without a defintion for it. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs