From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n4QJpRVT157972 for ; Tue, 26 May 2009 14:51:28 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 07B762AEA8E for ; Tue, 26 May 2009 12:51:40 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id fZv0cu71C0lNrs8U for ; Tue, 26 May 2009 12:51:40 -0700 (PDT) Date: Tue, 26 May 2009 15:51:40 -0400 From: Christoph Hellwig Subject: Re: [PATCH] drop xfs_version.h Message-ID: <20090526195140.GA4368@infradead.org> References: <4A1C449E.7070004@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4A1C449E.7070004@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs mailing list On Tue, May 26, 2009 at 02:35:58PM -0500, Eric Sandeen wrote: > xfs_version.h is about 30 lines for the benefit of > one single define, which seems a bit silly. > > Just drop the file and hardcode "SGI XFS" the 2 > places it's used. > > Signed-off-by: Eric Sandeen > - printk(KERN_INFO XFS_VERSION_STRING " with " > + printk(KERN_INFO "SGI XFS with " > XFS_BUILD_OPTIONS " enabled\n"); To prove that I can nitpick about even the most trivial patch: shouldn't this be merged into a single line now? :) Otherwise looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs