From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Richard.Ems@cape-horn-eng.com, xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfstests 206: test for overflow in growfs size calculation
Date: Fri, 29 May 2009 10:50:25 -0400 [thread overview]
Message-ID: <20090529145025.GA9205@infradead.org> (raw)
In-Reply-To: <4A1EFE55.4020505@sandeen.net>
On Thu, May 28, 2009 at 04:12:53PM -0500, Eric Sandeen wrote:
> Test trim of last small AG for large filesystem resizes
>
> As reported at
> http://article.gmane.org/gmane.comp.file-systems.xfs.general/29187
> this trimming may cause an overflow in the new size calculation.
>
> Patch to fix it, and testcase at
> http://article.gmane.org/gmane.comp.file-systems.xfs.general/29193
>
> V2: now with proper expected (resized) output!
This fails for me in really weird ways (Debian -testing, i386):
--- 206.out 2009-05-29 14:44:54.000000000 +0000
+++ 206.out.bad 2009-05-29 14:46:01.000000000 +0000
@@ -1,30 +1,18 @@
QA output created by 206
=== xfs_io ===
+ftruncate: File too large
=== mkfs.xfs ===
+existing superblock read failed: Success
+mkfs.xfs: pwrite64 failed: Invalid argument
meta-data=FILE isize=256 agcount=52, agsize=76288719 blks
= sectsz=512 attr=2
data = bsize=4096 blocks=3905982455, imaxpct=5
= sunit=0 swidth=0 blks
naming =version 2 bsize=4096 ascii-ci=0
-log =internal log bsize=4096 blocks=32768, version=2
- = sectsz=512 sunit=0 blks, lazy-count=0
-realtime =none extsz=4096 blocks=0, rtextents=0
-=== xfs_growfs ===
-meta-data=FILE isize=256 agcount=52, agsize=76288719 blks
- = sectsz=512 attr=2
-data = bsize=4096 blocks=3905982455, imaxpct=5
- = sunit=0 swidth=0 blks
-naming =version 2 bsize=4096 ascii-ci=0
-log =internal bsize=4096 blocks=32768, version=2
- = sectsz=512 sunit=0 blks, lazy-count=0
-realtime =none extsz=4096 blocks=0, rtextents=0
-data blocks changed from 3905982455 to 4882478016
-=== xfs_info ===
-meta-data=FILE isize=256 agcount=64, agsize=76288719 blks
- = sectsz=512 attr=2
-data = bsize=4096 blocks=4882478016, imaxpct=5
- = sunit=0 swidth=0 blks
-naming =version 2 bsize=4096 ascii-ci=0
-log =internal bsize=4096 blocks=32768, version=2
+log =internal log bsize=4096 blocks=521728, version=2
= sectsz=512 sunit=0 blks, lazy-count=0
realtime =none extsz=4096 blocks=0, rtextents=0
+mount: /dev/loop0: can't read superblock
+!!! failed to loopback mount
+(see 206.full for details)
+umount: /mnt/test/tmpdir.4994: not mounted
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-05-29 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 20:33 [PATCH] xfstests 206: test for overflow in growfs size calculation Eric Sandeen
2009-05-28 21:12 ` [PATCH V2] " Eric Sandeen
2009-05-29 14:50 ` Christoph Hellwig [this message]
2009-05-29 14:56 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529145025.GA9205@infradead.org \
--to=hch@infradead.org \
--cc=Richard.Ems@cape-horn-eng.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox