From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: reiserfs, gfs2, btrfs support
Date: Fri, 29 May 2009 15:45:00 -0400 [thread overview]
Message-ID: <20090529194500.GA20736@infradead.org> (raw)
In-Reply-To: <4A20373A.9070403@sandeen.net>
On Fri, May 29, 2009 at 02:27:54PM -0500, Eric Sandeen wrote:
> This patch gets reiserfs, gfs2, and btrfs off the ground.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
>
> diff --git a/common.rc b/common.rc
> index 54c36f3..c3e77e9 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -53,6 +53,14 @@ _mount_opts()
> # acls & xattrs aren't turned on by default on ext$FOO
> export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
> ;;
> + reiserfs)
> + # acls & xattrs aren't turned on by default on reiserfs
> + export MOUNT_OPTIONS="-o acl,user_xattr $REISERFS_MOUNT_OPTIONS"
> + ;;
> + gfs2)
> + # acls aren't turned on by default on gfs2
> + export MOUNT_OPTIONS="-o acl $GFS2_MOUNT_OPTIONS"
> + ;;
I wonder if we should find some way to auto-probe these options somehow.
It looks like lots of filesystems copied that utter braindamage from ext2 :(
Anyway the patch looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-05-29 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 19:27 [PATCH] xfstests: reiserfs, gfs2, btrfs support Eric Sandeen
2009-05-29 19:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529194500.GA20736@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox