From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH V3] xfstests: add aio-dio-regress tests
Date: Wed, 3 Jun 2009 15:38:46 -0400 [thread overview]
Message-ID: <20090603193845.GB4516@infradead.org> (raw)
In-Reply-To: <4A255E80.9000209@sandeen.net>
On Tue, Jun 02, 2009 at 12:16:48PM -0500, Eric Sandeen wrote:
> +AIO_TEST=aio-dio-extend-stat
> +
> +rm -f $TEST_DIR/aio-testfile
> +echo "==${AIO_TEST}=="
> +src/aio-dio-regress/$AIO_TEST $TEST_DIR/aio-testfile 2>&1
the AIO_TEST variable seems superflous in all these tests. Also
the echo isn't really strictly needed if only running one thing
anyway.
Modulo these nitpicks looks good to me,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2009-06-03 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 17:16 [PATCH V3] xfstests: add aio-dio-regress tests Eric Sandeen
2009-06-03 19:38 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603193845.GB4516@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox