public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfstests: fix for bash 3.2
@ 2009-06-04 13:03 Christoph Hellwig
  2009-06-04 13:33 ` Felix Blyakher
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2009-06-04 13:03 UTC (permalink / raw)
  To: xfs

Bash 3.2 wants a space before the closing "]" in a test:


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfstests-dev/check
===================================================================
--- xfstests-dev.orig/check	2009-06-04 12:36:21.000000000 +0000
+++ xfstests-dev/check	2009-06-04 12:36:26.000000000 +0000
@@ -160,7 +160,7 @@
 
 EOF
 
-if [ ! -z "$SCRATCH_DEV"]; then
+if [ ! -z "$SCRATCH_DEV" ]; then
   umount $SCRATCH_DEV 2>/dev/null
   # call the overridden mkfs - make sure the FS is built
   # the same as we'll create it later.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfstests: fix for bash 3.2
  2009-06-04 13:03 [PATCH] xfstests: fix for bash 3.2 Christoph Hellwig
@ 2009-06-04 13:33 ` Felix Blyakher
  0 siblings, 0 replies; 2+ messages in thread
From: Felix Blyakher @ 2009-06-04 13:33 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs


On Jun 4, 2009, at 8:03 AM, Christoph Hellwig wrote:

> Bash 3.2 wants a space before the closing "]" in a test:
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Felix Blyakher <felixb@sgi.com>

>
>
> Index: xfstests-dev/check
> ===================================================================
> --- xfstests-dev.orig/check	2009-06-04 12:36:21.000000000 +0000
> +++ xfstests-dev/check	2009-06-04 12:36:26.000000000 +0000
> @@ -160,7 +160,7 @@
>
> EOF
>
> -if [ ! -z "$SCRATCH_DEV"]; then
> +if [ ! -z "$SCRATCH_DEV" ]; then
>   umount $SCRATCH_DEV 2>/dev/null
>   # call the overridden mkfs - make sure the FS is built
>   # the same as we'll create it later.
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-06-04 13:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-04 13:03 [PATCH] xfstests: fix for bash 3.2 Christoph Hellwig
2009-06-04 13:33 ` Felix Blyakher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox