From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eric Sandeen <sandeen@sandeen.net>,
xfs@oss.sgi.com
Subject: Re: [PATCH 5/5] xfs: fix xfs_quiesce_data
Date: Fri, 5 Jun 2009 06:41:57 -0400 [thread overview]
Message-ID: <20090605104157.GA25032@infradead.org> (raw)
In-Reply-To: <20090604094512.GU16929@discord.disaster>
On Thu, Jun 04, 2009 at 07:45:12PM +1000, Dave Chinner wrote:
> On Mon, May 11, 2009 at 04:15:11PM -0400, Christoph Hellwig wrote:
> > On Sun, May 10, 2009 at 01:37:58PM -0500, Eric Sandeen wrote:
> > > I guess I too would like a reason for the filestream_flush move
> > > somewhere in the changelog...
> >
> > Hehe, maybe Dave can chime in. Or I can test if it actually affects
> > anything and maybe move it out to another patch. The lack of
> > reliability of the filesystreams tests doesn't make this any easier to
> > test.
>
> (Just catching up on my mail backlog)
>
> I think that the filestream_flush() call should actually be after
> the data flush. filestream_flush() is used to clear the filestream
> association cache which holds references to the inodes.
>
> Where the flush is currently placed is destroying the association
> that defines the AG the data should be written to before the data is
> written. As a result it may not end up in the AG carefully
> associated with the inode during the write() syscall.
>
> This may be one of the reasons for the filestreams tests failing
> frequently....
Makes sense. I stil get reliable failures on 171 and 172, but the
others seem to pass with these changes.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-06-05 10:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 14:03 [PATCH 0/5] fix sync (test 182, grub) Christoph Hellwig
2009-04-26 14:03 ` [PATCH 1/5] xfs: remove ->write_super and stop maintaining ->s_dirt Christoph Hellwig
2009-05-10 16:25 ` Eric Sandeen
2009-05-10 16:30 ` Eric Sandeen
2009-05-10 17:37 ` Eric Sandeen
2009-04-26 14:03 ` [PATCH 2/5] xfs: cleanup ->sync_fs Christoph Hellwig
2009-05-10 17:51 ` Eric Sandeen
2009-05-11 20:11 ` Christoph Hellwig
2009-04-26 14:03 ` [PATCH 3/5] xfs: make inodes dirty before issuing I/O Christoph Hellwig
2009-05-10 18:02 ` Eric Sandeen
2009-04-26 14:03 ` [PATCH 4/5] xfs: make sure xfs_sync_fsdata covers the log Christoph Hellwig
2009-05-10 18:29 ` Eric Sandeen
2009-04-26 14:03 ` [PATCH 5/5] xfs: fix xfs_quiesce_data Christoph Hellwig
2009-05-10 18:37 ` Eric Sandeen
2009-05-11 20:15 ` Christoph Hellwig
2009-06-04 9:45 ` Dave Chinner
2009-06-05 10:41 ` Christoph Hellwig [this message]
2009-05-06 9:33 ` [PATCH 0/5] fix sync (test 182, grub) Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605104157.GA25032@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox