Fwd: Bug#531950: attr: FTBFS on GNU/kFreeBSD

Fwd: Bug#531950: attr: FTBFS on GNU/kFreeBSD

[Nathan Scott]

Could someone verify and merge this patch?  It looks OK to
me.

thanks!

----- Forwarded Message -----
From: "Petr Salinger" <Petr.Salinger@seznam.cz>
To: submit@bugs.debian.org
Sent: Friday, June 5, 2009 6:45:33 PM GMT +10:00 Canberra / Melbourne / Sydney
Subject: Bug#531950: attr: FTBFS on GNU/kFreeBSD

Package: attr
Severity: important
Version: 1:2.4.43-2
Tags: patch
User: glibc-bsd-devel@lists.alioth.debian.org
Usertags: kfreebsd

Hi,

the current version fails to build on GNU/kFreeBSD.
It is kind of reopen of #414232.
Please use the patch bellow instead of the patch in #414232.

It might look surprisingly, but it is correct for all architectures.

The Linux uses ENODATA and does not define ENOATTR,
the GNU/kFreeBSD uses ENOATTR and does not define ENODATA
in errno.h (similarly as original SGI code).
Therefore the code in attr mainly uses ENOATTR,
see also include/xattr.h.

It would also be nice if you can ask upstream
to include this change.

Thanks in advance


Petr

only in patch2:
unchanged:
--- attr-2.4.43.orig/getfattr/getfattr.c
+++ attr-2.4.43/getfattr/getfattr.c
@@ -93,7 +93,7 @@

  const char *strerror_ea(int err)
  {
-       if (err == ENODATA)
+       if (err == ENOATTR)
                 return _("No such attribute");
         return strerror(err);
  }
only in patch2:
unchanged:
--- attr-2.4.43.orig/setfattr/setfattr.c
+++ attr-2.4.43/setfattr/setfattr.c
@@ -66,7 +66,7 @@

  const char *strerror_ea(int err)
  {
-       if (err == ENODATA)
+       if (err == ENOATTR)
                 return _("No such attribute");
         return strerror(err);
  }




-- 
Nathan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: Fwd: Bug#531950: attr: FTBFS on GNU/kFreeBSD

[Christoph Hellwig]

On Tue, Jun 09, 2009 at 10:03:28AM +1000, Nathan Scott wrote:
> Could someone verify and merge this patch?  It looks OK to
> me.

Andreas now takes care ot attr.  Btw, the submitter should stop that
stupid GNU wanking - errnos are defined by the kernel so it's a FreeBSD
issues and has nothing to do with their glibc abuse.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs