public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Petr Salinger <Petr.Salinger@seznam.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
	531950-quiet@bugs.debian.org, xfs@oss.sgi.com,
	Nathan Scott <nscott@aconex.com>
Subject: Re: Bug#531950: attr: FTBFS on GNU/kFreeBSD
Date: Tue, 9 Jun 2009 08:10:42 -0400	[thread overview]
Message-ID: <20090609121042.GA28666@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0906091328270.31325@sci.felk.cvut.cz>

On Tue, Jun 09, 2009 at 01:35:58PM +0200, Petr Salinger wrote:
> The problem is that there is no ENODATA errno value defined
> on GNU/kFreeBSD. The errno values are determined by kernel,
> they are the same as on plain FreeBSD, used libc
> implementation does not change it.
>
> Another possibility is to use patch bellow.
> Does it looks acceptable for you ?

This one looks better to me, except that I would really make this
an explicit #ifdef __linux__.  The lack of a proper ENOATTR is
a Linux specific quirck and not related to the presence of
non-standard ENODATA.  Maybe also add a little comment why
we're doing this so people don't get confused by it.

Btw, how does libattr actually work for you on FreeBSD?  Last time
I checked FreeBSD had slightly different xattr system calls that (just
like IRIX) used an integer namespace value instead of the string prefix
in Linux.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-06-09 12:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1450746396.6081061244543230576.JavaMail.root@mail-au.aconex.com>
2009-06-09 10:31 ` Bug#531950: attr: FTBFS on GNU/kFreeBSD Nathan Scott
2009-06-09 11:35   ` Petr Salinger
2009-06-09 12:10     ` Christoph Hellwig [this message]
2009-06-14 16:35       ` Aurelien Jarno
2009-06-14 20:33         ` Christoph Hellwig
2009-06-14 20:56           ` Aurelien Jarno
2009-06-15  9:42             ` Christoph Hellwig
2009-06-15 10:26               ` Petr Salinger
2009-06-15 10:05                 ` Aurelien Jarno
2009-06-19 15:37                 ` Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090609121042.GA28666@infradead.org \
    --to=hch@infradead.org \
    --cc=531950-quiet@bugs.debian.org \
    --cc=Petr.Salinger@seznam.cz \
    --cc=nscott@aconex.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox