[PATCH] xfs: fix freeing memory in xfs_getbmap()

[PATCH] xfs: fix freeing memory in xfs_getbmap()

[Felix Blyakher]

Regression from commit 28e211700a81b0a934b6c7a4b8e7dda843634d2f.
Need to free temporary buffer allocated in xfs_getbmap().

Signed-off-by: Felix Blyakher <felixb@sgi.com>
Signed-off-by: Hedi Berriche <hedi@sgi.com>
---
 fs/xfs/xfs_bmap.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c
index 4b0f6ef..7928b99 100644
--- a/fs/xfs/xfs_bmap.c
+++ b/fs/xfs/xfs_bmap.c
@@ -6086,6 +6086,7 @@ xfs_getbmap(
 			break;
 	}
 
+	kmem_free(out);
 	return error;
 }
 
-- 
1.5.4.rc3

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs: fix freeing memory in xfs_getbmap()

[Christoph Hellwig]

On Thu, Jun 11, 2009 at 05:16:25PM -0500, Felix Blyakher wrote:
> Regression from commit 28e211700a81b0a934b6c7a4b8e7dda843634d2f.
> Need to free temporary buffer allocated in xfs_getbmap().

Defintively need to free it.  Not sure where it got lost from my initial
patch to the one that got merged, sorry.

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs