From: Christoph Hellwig <hch@infradead.org>
To: Felix Blyakher <felixb@sgi.com>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: implement ->dirty_inode callout
Date: Tue, 23 Jun 2009 17:30:43 -0400 [thread overview]
Message-ID: <20090623213043.GA13921@infradead.org> (raw)
In-Reply-To: <EBC1B5EB-A971-4769-8E2A-9C15BB069E11@sgi.com>
On Tue, Jun 23, 2009 at 10:38:43AM -0500, Felix Blyakher wrote:
> I'd like to (re)propose Dave's patch from the last October to
> address the problem of atime never making to the disk. Many
> people complained about it.
> I may have slightly adjusted the patch to fit the latest
> code, and verified it addresses the issue.
>
> The reference to the discussion on this matter on xfs mailing
> list is here:
>
> http://oss.sgi.com/archives/xfs/2008-10/msg02102.html
Can you run some benchmarks to see what impact it has with the
new relatime default?
The only places where we actual look at i_update_core are fsync and
the decision wether to flush out the inode fully in reclaim and
I we should sync out the inode there.
The VFS ends up calling into ->dirty_inode from the following places:
- set_page_dirty
- mark_buffer_dirty
- touch_atime
- file_update_time
- generic_file_direct_write
And it doesn't distinguish between setting I_DIRTY_SYNC and
I_DIRTY_DATASYNC which means we'll also get it for the first two
events which only affect the data and not the inode core.
I'd be much more comfortable if we'd pass down those flags to
->dirty_inode and optimize based on that.
On the bright side this patch will also allow us to hack around the VFS
layering violation which currently causes missed c/mtime updates on
mmaped writes.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-06-23 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 15:38 [PATCH] xfs: implement ->dirty_inode callout Felix Blyakher
2009-06-23 21:30 ` Christoph Hellwig [this message]
2009-06-29 8:14 ` Michael Weissenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623213043.GA13921@infradead.org \
--to=hch@infradead.org \
--cc=felixb@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox