From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: small common.config cleanup
Date: Tue, 7 Jul 2009 06:33:38 -0400 [thread overview]
Message-ID: <20090707103338.GC20410@infradead.org> (raw)
In-Reply-To: <20090620173818.GA26809@infradead.org>
ping?
On Sat, Jun 20, 2009 at 01:38:18PM -0400, Christoph Hellwig wrote:
> Don't list various non-mandatory options near the check for the
> mandatory ones, and make the test for the mandatory ones a proper if
> statements.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfstests-dev/common.config
> ===================================================================
> --- xfstests-dev.orig/common.config 2009-06-20 19:15:14.576805079 +0200
> +++ xfstests-dev/common.config 2009-06-20 19:16:48.956930262 +0200
> @@ -191,27 +191,18 @@ known_hosts()
> [ -f $HOST_CONFIG_DIR/$HOST ] && . $HOST_CONFIG_DIR/$HOST
> [ -f $HOST_CONFIG_DIR/$HOST.config ] && . $HOST_CONFIG_DIR/$HOST.config
>
> + # Mandatory Config values.
> MC=""
> -# Non-Mandatory Config values.
> -# [ -z "$MODULAR" ] && MC="$MC MODULAR"
> -# [ -z "$TEST_LOGDEV" ] && MC="$MC TEST_LOGDEV"
> -# [ -z "$SCRATCH_LOGDEV" ] && MC="$MC SCRATCH_LOGDEV"
> -# [ -z "$SCRATCH_RTDEV" ] && MC="$MC SCRATCH_RTDEV"
> -# [ -z "$SCRATCH_MNT" ] && MC="$MC SCRATCH_MNT"
> -# [ -z "$SCRATCH_DEV" ] && MC="$MC SCRATCH_DEV"
> -
> [ -z "$EMAIL" ] && MC="$MC EMAIL"
> [ -z "$TEST_DIR" ] && MC="$MC TEST_DIR"
> [ -z "$TEST_DEV" ] && MC="$MC TEST_DEV"
>
> - [ "$MC" ] && (echo "Warning: need to define parameters for host $HOST";\
> - echo " or set variables:"; \
> - echo " $MC")
> -# if [ -e configs/$HOST.config ]
> -# then echo "Not carring, we have a configfile ($HOST_CONFIG_DIR/$HOST)"
> -# else
> - [ "$MC" ] && exit 1
> -# fi
> + if [ -n "$MC" ]; then
> + echo "Warning: need to define parameters for host $HOST"
> + echo " or set variables:"
> + echo " $MC"
> + exit 1
> + fi
> }
>
> if [ -f "$HOST_OPTIONS" ]; then
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-07-07 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 17:38 [PATCH] xfstests: small common.config cleanup Christoph Hellwig
2009-07-07 10:33 ` Christoph Hellwig [this message]
2009-07-07 14:05 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090707103338.GC20410@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox