From: Christoph Hellwig <hch@infradead.org>
To: Paul Smith <paul@mad-scientist.net>
Cc: Linux XFS <linux-xfs@oss.sgi.com>, david chinner <dgc@sgi.com>,
linux-kernel@vger.kernel.org,
christoph hellwig <hch@ifradead.org>
Subject: Re: [2.6.27.25] assfail in xfs_attr_quiesce() during umount
Date: Tue, 7 Jul 2009 15:06:43 -0400 [thread overview]
Message-ID: <20090707190643.GA32467@infradead.org> (raw)
In-Reply-To: <MAIL10OSN4RHlLx5ERz0002f238@mail1.netezza.com>
On Tue, Jul 07, 2009 at 02:42:16PM -0400, Paul Smith wrote:
> According to the thread for the former, it was intended to be resolved
> by "proper per-vfsmount write count in 2.6.25 as part of the per-mount
> r/o patches" (C.Hellwig)
>
> Did those fixes indeed go into 2.6.25 (or 2.6.27 or below)? Was there
> something else that needed to be done for XFS to be able take advantage
> of that enhancement?
We haven't fixed the VFS issues yet. In some later kernel we just
changed the assert to a warn on for now until the issue is sorted out.
> And, is the patch posted by DavidC here:
> http://marc.info/?l=linux-kernel&m=120106649923499&w=2
It looks somehwat dangerous for me. For now I would just comment
out the assert or change it to a WARN_ON as in the newer kernels.
I've recently started looking at that area in the VFS again and I'll
hopefully make progress on a solution that sets MS_RDONLY at the
correct time.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-07-07 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 18:42 [2.6.27.25] assfail in xfs_attr_quiesce() during umount Paul Smith
2009-07-07 19:06 ` Christoph Hellwig [this message]
2009-07-07 20:18 ` Paul Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090707190643.GA32467@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=hch@ifradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@oss.sgi.com \
--cc=paul@mad-scientist.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox