From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n6JIJVli239687 for ; Sun, 19 Jul 2009 13:19:32 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 88E0636FEC6 for ; Sun, 19 Jul 2009 11:20:13 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id t0iaxr3EaLKqByE7 for ; Sun, 19 Jul 2009 11:20:13 -0700 (PDT) Date: Sun, 19 Jul 2009 14:20:12 -0400 From: Christoph Hellwig Subject: Re: xfstests: nslookup not found Message-ID: <20090719182012.GA10936@infradead.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christian Kujau Cc: linux-xfs@oss.sgi.com On Sun, Jul 19, 2009 at 10:57:35AM -0700, Christian Kujau wrote: > Hi, > > while trying to run ./check in a current xfstests tree, execution stopped > because "nslookup" was not available. I could've just installed this tool > but I wondered why xfstests, a filesystem testing tool, would need > nslookup at all. Turns out that it's being used in a routine called > "_get_fqdn", which in turn is only called once in ./new, to set a variable > called "owner" and I ask myself: do I really want my FQDN listed in the > testresults, that maybe even get published for analysis? I changed this > whole _get_fqdn thingy to just "uname -n", but I'm eager to know why the > FQDN is crucial here :-) It uses it as email address for the test owner. In these days this probably requires hand-editing anyway, but the fqdn is certainly a better approximation than uname -n. Can you resend a patch that just moves _get_fqdn and the check for nslookup from common* into the "new" script? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs