[PATCH] use XFS_CORRUPTION_ERROR in xfs_btree_check_sblock

[PATCH] use XFS_CORRUPTION_ERROR in xfs_btree_check_sblock

[Eric Sandeen]

In Red Hat Bug 512552
 - Can't write to XFS mount during raid5 resync

a user ran into corruption while resyncing a raid, and we failed
a consistency test, but didn't get much more info; it'd be nice
to call XFS_CORRUPTION_ERROR here so we can see the buffer
contents.

Compile-tested only...

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/fs/xfs/xfs_btree.c b/fs/xfs/xfs_btree.c
index e9df995..2671738 100644
--- a/fs/xfs/xfs_btree.c
+++ b/fs/xfs/xfs_btree.c
@@ -120,8 +120,8 @@ xfs_btree_check_sblock(
 			XFS_RANDOM_BTREE_CHECK_SBLOCK))) {
 		if (bp)
 			xfs_buftrace("SBTREE ERROR", bp);
-		XFS_ERROR_REPORT("xfs_btree_check_sblock", XFS_ERRLEVEL_LOW,
-				 cur->bc_mp);
+		XFS_CORRUPTION_ERROR("xfs_btree_check_sblock",
+			XFS_ERRLEVEL_LOW, cur->bc_mp, block);
 		return XFS_ERROR(EFSCORRUPTED);
 	}
 	return 0;

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] use XFS_CORRUPTION_ERROR in xfs_btree_check_sblock

[Christoph Hellwig]

On Mon, Jul 20, 2009 at 10:52:15AM -0500, Eric Sandeen wrote:
> In Red Hat Bug 512552
>  - Can't write to XFS mount during raid5 resync
> 
> a user ran into corruption while resyncing a raid, and we failed
> a consistency test, but didn't get much more info; it'd be nice
> to call XFS_CORRUPTION_ERROR here so we can see the buffer
> contents.
> 
> Compile-tested only...

Looks good to me, I'll throw it into my XFSQA queue..

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] use XFS_CORRUPTION_ERROR in xfs_btree_check_sblock

[Christoph Hellwig]

On Mon, Jul 20, 2009 at 05:21:53PM -0400, Christoph Hellwig wrote:
> On Mon, Jul 20, 2009 at 10:52:15AM -0500, Eric Sandeen wrote:
> > In Red Hat Bug 512552
> >  - Can't write to XFS mount during raid5 resync
> > 
> > a user ran into corruption while resyncing a raid, and we failed
> > a consistency test, but didn't get much more info; it'd be nice
> > to call XFS_CORRUPTION_ERROR here so we can see the buffer
> > contents.
> > 
> > Compile-tested only...
> 
> Looks good to me, I'll throw it into my XFSQA queue..

I has survied quite a few xfsqa runs for me, so


Reviewed-by: Christoph Hellwig <hch@lst.de>

sounds like another 2.6.31 candidate to me..

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs