From: Theodore Tso <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] Add ext2/3/4-specific _check_extN_filesystem function
Date: Tue, 18 Aug 2009 13:04:56 -0400 [thread overview]
Message-ID: <20090818170456.GF28560@mit.edu> (raw)
In-Reply-To: <20090818161116.GA2162@infradead.org>
On Tue, Aug 18, 2009 at 12:11:16PM -0400, Christoph Hellwig wrote:
> On Tue, Aug 18, 2009 at 10:57:47AM -0400, Theodore Ts'o wrote:
> > The _check_generic_filesystem function doesn't force a full filesystem
> > check, so filesystem inconsistencies after a test wouldn't be noticed.
> > To fix this, I added an extN specific check filesystem function.
>
> Looks like the only difference between the generic and the extN
> check routine is the addition of -f to the fsck command line. What
> about just introducing a _fsck_args similar to _mount_opts where
> filesystems can set their additional required mount options?
That would work, yeah, and would be result in far less code
duplication in common.rc. I'll take a whack at it and resubmit.
Thanks,
- Ted
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-08-18 17:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 14:57 [PATCH] Add ext2/3/4-specific _check_extN_filesystem function Theodore Ts'o
2009-08-18 16:11 ` Christoph Hellwig
2009-08-18 17:04 ` Theodore Tso [this message]
2009-08-26 22:12 ` Christoph Hellwig
2009-08-27 2:05 ` Theodore Tso
2009-08-27 21:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090818170456.GF28560@mit.edu \
--to=tytso@mit.edu \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox