public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Michael Monnerie <michael.monnerie@is.it-management.at>
Cc: xfs@oss.sgi.com
Subject: Re: disk performance strange/low
Date: Wed, 26 Aug 2009 13:56:04 -0400	[thread overview]
Message-ID: <20090826175603.GA14019@infradead.org> (raw)
In-Reply-To: <200908261920.47054@zmi.at>

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

On Wed, Aug 26, 2009 at 07:20:36PM +0200, Michael Monnerie wrote:
> On Dienstag 18 August 2009 Christoph Hellwig wrote:
> > On Tue, Aug 18, 2009 at 04:08:05AM +0200, Michael Monnerie wrote:
> > > On Montag 17 August 2009 Christoph Hellwig wrote:
> > > > Yes, that sounds like the problem of the VM not feeding us enough
> > > > pages to write. ?What kernel is this on? ?Latest 2.6.31-rc has a
> > > > workaround for it.
> > >
> > > 2.6.27.23-0.1-xen from openSUSE 11.1
> > > I can't switch as I use it with the free Xen. Thanks for the info.
> >
> > Try backporting commit c8a4051c3731b6db224482218cfd535ab9393ff8 from
> > mainline - it should apply just fine to a 2.6.27-ish kernel.
> 
> Thank you. I'm not a patcher, could you tell me how to do that?

Just take the patch I attached and apply it using

	patch -p1 < xfs-nr-to-write.diff

if you want to make sure it applies cleanly do a

	patch -p1 --dry-run < xfs-nr-to-write.diff

beforee to check if it doesn't cause any reject.

After that rebuild your kernel.

[-- Attachment #2: xfs-nr-to-write.diff --]
[-- Type: text/plain, Size: 1239 bytes --]

commit c8a4051c3731b6db224482218cfd535ab9393ff8
Author: Eric Sandeen <sandeen@sandeen.net>
Date:   Fri Jul 31 00:02:17 2009 -0500

    xfs: bump up nr_to_write in xfs_vm_writepage
    
    VM calculation for nr_to_write seems off.  Bump it way
    up, this gets simple streaming writes zippy again.
    To be reviewed again after Jens' writeback changes.
    
    Signed-off-by: Christoph Hellwig <hch@infradead.org>
    Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
    Cc: Chris Mason <chris.mason@oracle.com>
    Reviewed-by: Felix Blyakher <felixb@sgi.com>
    Signed-off-by: Felix Blyakher <felixb@sgi.com>

diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c
index 7ec89fc..aecf251 100644
--- a/fs/xfs/linux-2.6/xfs_aops.c
+++ b/fs/xfs/linux-2.6/xfs_aops.c
@@ -1268,6 +1268,14 @@ xfs_vm_writepage(
 	if (!page_has_buffers(page))
 		create_empty_buffers(page, 1 << inode->i_blkbits, 0);
 
+
+	/*
+	 *  VM calculation for nr_to_write seems off.  Bump it way
+	 *  up, this gets simple streaming writes zippy again.
+	 *  To be reviewed again after Jens' writeback changes.
+	 */
+	wbc->nr_to_write *= 4;
+
 	/*
 	 * Convert delayed allocate, unwritten or unmapped space
 	 * to real space and flush out to disk.

[-- Attachment #3: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2009-08-26 17:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 21:11 disk performance strange/low Michael Monnerie
2009-08-17 21:41 ` Christoph Hellwig
2009-08-18  2:08   ` Michael Monnerie
2009-08-18  2:43     ` Christoph Hellwig
2009-08-26 17:20       ` Michael Monnerie
2009-08-26 17:56         ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090826175603.GA14019@infradead.org \
    --to=hch@infradead.org \
    --cc=michael.monnerie@is.it-management.at \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox