public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_io: actually issue 0 size writes
Date: Wed, 26 Aug 2009 18:11:06 -0400	[thread overview]
Message-ID: <20090826221106.GB18119@infradead.org> (raw)
In-Reply-To: <4A849096.1010600@sandeen.net>

On Thu, Aug 13, 2009 at 05:15:50PM -0500, Eric Sandeen wrote:
> While testing some stuff in generic_write_checks() in the
> kernel I realized that you can't actually use xfs_io to send
> a 0-byte write in.  This is actually a condition worth testing:
> 
>        If  count  is zero and fd refers to a regular file,
>        then write() may return a failure status if one  of
>        the  errors  below  is  detected.  If no errors are
>        detected, 0 will be returned  without  causing  any
>        other  effect.
> 
> So fix that up.
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Any reason you didn't put this in despite two positive reviews?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2009-08-26 22:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-13 22:15 [PATCH] xfs_io: actually issue 0 size writes Eric Sandeen
2009-08-13 22:52 ` Felix Blyakher
2009-08-14  0:15   ` Eric Sandeen
2009-08-26 22:11 ` Christoph Hellwig [this message]
2009-08-26 23:26   ` Eric Sandeen
     [not found] <139598026.1934901250211190252.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-08-14  0:56 ` Lachlan McIlroy
2009-08-14  1:34   ` Eric Sandeen
     [not found] <148381776.1936161250214905902.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-08-14  1:55 ` Lachlan McIlroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090826221106.GB18119@infradead.org \
    --to=hch@infradead.org \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox