From: Christoph Hellwig <hch@infradead.org>
To: Theodore Tso <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] Add ext2/3/4-specific _check_extN_filesystem function
Date: Wed, 26 Aug 2009 18:12:01 -0400 [thread overview]
Message-ID: <20090826221201.GC18119@infradead.org> (raw)
In-Reply-To: <20090818170456.GF28560@mit.edu>
On Tue, Aug 18, 2009 at 01:04:56PM -0400, Theodore Tso wrote:
> > Looks like the only difference between the generic and the extN
> > check routine is the addition of -f to the fsck command line. What
> > about just introducing a _fsck_args similar to _mount_opts where
> > filesystems can set their additional required mount options?
>
> That would work, yeah, and would be result in far less code
> duplication in common.rc. I'll take a whack at it and resubmit.
Are you still going to look at it realtively soon? If not I'll just
put this version in to imrove the test coverage on extN and we can
clean it up later.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-08-26 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 14:57 [PATCH] Add ext2/3/4-specific _check_extN_filesystem function Theodore Ts'o
2009-08-18 16:11 ` Christoph Hellwig
2009-08-18 17:04 ` Theodore Tso
2009-08-26 22:12 ` Christoph Hellwig [this message]
2009-08-27 2:05 ` Theodore Tso
2009-08-27 21:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090826221201.GC18119@infradead.org \
--to=hch@infradead.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox