* [PATCH] xfs: actually enable the swapext compat handler
@ 2009-09-01 18:03 Christoph Hellwig
2009-09-01 19:45 ` Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2009-09-01 18:03 UTC (permalink / raw)
To: xfs
Fix a small typo in the compat ioctl handler that cause the swapext
compat handler to never be called.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Torsten Kaiser <just.for.lkml@googlemail.com>
Tested-by: Torsten Kaiser <just.for.lkml@googlemail.com>
Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
===================================================================
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:06.093044591 -0300
+++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:10.856544216 -0300
@@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
case XFS_IOC_GETVERSION_32:
cmd = _NATIVE_IOC(cmd, long);
return xfs_file_ioctl(filp, cmd, p);
- case XFS_IOC_SWAPEXT: {
+ case XFS_IOC_SWAPEXT_32: {
struct xfs_swapext sxp;
struct compat_xfs_swapext __user *sxu = arg;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: actually enable the swapext compat handler
2009-09-01 18:03 [PATCH] xfs: actually enable the swapext compat handler Christoph Hellwig
@ 2009-09-01 19:45 ` Eric Sandeen
2009-09-01 20:13 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2009-09-01 19:45 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> Fix a small typo in the compat ioctl handler that cause the swapext
> compat handler to never be called.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Torsten Kaiser <just.for.lkml@googlemail.com>
> Tested-by: Torsten Kaiser <just.for.lkml@googlemail.com>
Guilty-party: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:06.093044591 -0300
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:10.856544216 -0300
> @@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
> case XFS_IOC_GETVERSION_32:
> cmd = _NATIVE_IOC(cmd, long);
> return xfs_file_ioctl(filp, cmd, p);
> - case XFS_IOC_SWAPEXT: {
> + case XFS_IOC_SWAPEXT_32: {
> struct xfs_swapext sxp;
> struct compat_xfs_swapext __user *sxu = arg;
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: actually enable the swapext compat handler
2009-09-01 19:45 ` Eric Sandeen
@ 2009-09-01 20:13 ` Christoph Hellwig
2009-09-01 21:22 ` Felix Blyakher
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2009-09-01 20:13 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Christoph Hellwig, xfs
On Tue, Sep 01, 2009 at 02:45:59PM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > Fix a small typo in the compat ioctl handler that cause the swapext
> > compat handler to never be called.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Torsten Kaiser <just.for.lkml@googlemail.com>
> > Tested-by: Torsten Kaiser <just.for.lkml@googlemail.com>
>
> Guilty-party: Eric Sandeen <sandeen@sandeen.net>
> Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Haha, thanks. Felix, can you push this one to Linus for 2.6.31?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: actually enable the swapext compat handler
2009-09-01 20:13 ` Christoph Hellwig
@ 2009-09-01 21:22 ` Felix Blyakher
0 siblings, 0 replies; 4+ messages in thread
From: Felix Blyakher @ 2009-09-01 21:22 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Eric Sandeen, xfs
On Sep 1, 2009, at 3:13 PM, Christoph Hellwig wrote:
> On Tue, Sep 01, 2009 at 02:45:59PM -0500, Eric Sandeen wrote:
>> Christoph Hellwig wrote:
>>> Fix a small typo in the compat ioctl handler that cause the swapext
>>> compat handler to never be called.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>> Reviewed-by: Torsten Kaiser <just.for.lkml@googlemail.com>
>>> Tested-by: Torsten Kaiser <just.for.lkml@googlemail.com>
>>
>> Guilty-party: Eric Sandeen <sandeen@sandeen.net>
>> Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
Yep, trivial fix. Looks good.
Reviewed-by: Felix Blyakher <felixb@sgi.com>
>>
>
> Haha, thanks. Felix, can you push this one to Linus for 2.6.31?
Sure, doing it now.
Felix
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-09-01 21:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-01 18:03 [PATCH] xfs: actually enable the swapext compat handler Christoph Hellwig
2009-09-01 19:45 ` Eric Sandeen
2009-09-01 20:13 ` Christoph Hellwig
2009-09-01 21:22 ` Felix Blyakher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox