public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: un-static xfs_inobt_lookup
@ 2009-09-01 23:56 Christoph Hellwig
  2009-09-02  1:37 ` Felix Blyakher
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2009-09-01 23:56 UTC (permalink / raw)
  To: xfs


xfs_inobt_lookup is also used in xfs_itable.c, remove the STATIC modifier
from it's declaration to fix non-debug builds.

This was already fixed in my git tree vs the version last posted to the
list.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfs/fs/xfs/xfs_ialloc.c
===================================================================
--- xfs.orig/fs/xfs/xfs_ialloc.c	2009-09-01 20:47:28.515468366 -0300
+++ xfs/fs/xfs/xfs_ialloc.c	2009-09-01 20:47:33.867913011 -0300
@@ -59,7 +59,7 @@ xfs_ialloc_cluster_alignment(
 /*
  * Lookup a record by ino in the btree given by cur.
  */
-STATIC int				/* error */
+int					/* error */
 xfs_inobt_lookup(
 	struct xfs_btree_cur	*cur,	/* btree cursor */
 	xfs_agino_t		ino,	/* starting inode of chunk */

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfs: un-static xfs_inobt_lookup
  2009-09-01 23:56 [PATCH] xfs: un-static xfs_inobt_lookup Christoph Hellwig
@ 2009-09-02  1:37 ` Felix Blyakher
  0 siblings, 0 replies; 2+ messages in thread
From: Felix Blyakher @ 2009-09-02  1:37 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs


On Sep 1, 2009, at 6:56 PM, Christoph Hellwig wrote:

>
> xfs_inobt_lookup is also used in xfs_itable.c, remove the STATIC  
> modifier
> from it's declaration to fix non-debug builds.

Argh! I think, this or similar thing bit us once in past.

>
>
> This was already fixed in my git tree vs the version last posted to  
> the
> list.

Applying it quickly to the oss as well.

> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Felix Blyakher <felixb@sgi.com>

>
>
> Index: xfs/fs/xfs/xfs_ialloc.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_ialloc.c	2009-09-01 20:47:28.515468366 -0300
> +++ xfs/fs/xfs/xfs_ialloc.c	2009-09-01 20:47:33.867913011 -0300
> @@ -59,7 +59,7 @@ xfs_ialloc_cluster_alignment(
> /*
>  * Lookup a record by ino in the btree given by cur.
>  */
> -STATIC int				/* error */
> +int					/* error */
> xfs_inobt_lookup(
> 	struct xfs_btree_cur	*cur,	/* btree cursor */
> 	xfs_agino_t		ino,	/* starting inode of chunk */
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-09-02  2:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-01 23:56 [PATCH] xfs: un-static xfs_inobt_lookup Christoph Hellwig
2009-09-02  1:37 ` Felix Blyakher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox