From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: use correct log reservation when handling ENOSPC in xfs_create
Date: Thu, 3 Sep 2009 11:46:11 -0400 [thread overview]
Message-ID: <20090903154611.GB16715@infradead.org> (raw)
In-Reply-To: <20090826113736.GA15562@infradead.org>
ping?
On Wed, Aug 26, 2009 at 07:37:36AM -0400, Christoph Hellwig wrote:
> We added the ENOSPC handling patch in xfs_create just after it got mered
> with xfs_mkdir. Change the log reservation to the variable for either
> the create or mkdir value so it does the right thing if get here for creating
> a directory.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/xfs/xfs_vnodeops.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_vnodeops.c 2009-08-24 11:35:52.794261954 -0300
> +++ xfs/fs/xfs/xfs_vnodeops.c 2009-08-24 11:36:25.466636450 -0300
> @@ -1479,8 +1479,8 @@ xfs_create(
> if (error == ENOSPC) {
> /* flush outstanding delalloc blocks and retry */
> xfs_flush_inodes(dp);
> - error = xfs_trans_reserve(tp, resblks, XFS_CREATE_LOG_RES(mp), 0,
> - XFS_TRANS_PERM_LOG_RES, XFS_CREATE_LOG_COUNT);
> + error = xfs_trans_reserve(tp, resblks, log_res, 0,
> + XFS_TRANS_PERM_LOG_RES, log_count);
> }
> if (error == ENOSPC) {
> /* No space at all so try a "no-allocation" reservation */
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-09-03 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 11:37 [PATCH] xfs: use correct log reservation when handling ENOSPC in xfs_create Christoph Hellwig
2009-09-03 15:46 ` Christoph Hellwig [this message]
2009-09-03 16:35 ` [PATCH] xfs: use correct log reservation when handling ENOSPC inxfs_create Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903154611.GB16715@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox