From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: Re: PATCH] xfs: implement .dirty_inode to fix timestamp handling
Date: Thu, 10 Sep 2009 12:08:19 -0400 [thread overview]
Message-ID: <20090910160819.GA21031@infradead.org> (raw)
In-Reply-To: <20090901180820.GB26071@infradead.org>
On Tue, Sep 01, 2009 at 02:08:20PM -0400, Christoph Hellwig wrote:
> I managed to trigger the ASSERT in the reclaim path, so it looks both
> this version and our previous code is buggy. It's back to the drawing
> board for now until I gifure out what's going on.
Okay, figured it out - didn't actually test the asserts as the were
added last minute. Looks like we could always (before and after the
patch) get into the reclaim path with the timestamp in the xfs inode not
uptodate, and due to the I_CLEAR check we would never update it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-09-10 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 3:12 PATCH] xfs: implement .dirty_inode to fix timestamp handling Christoph Hellwig
2009-08-27 6:40 ` Felix Blyakher
2009-08-27 12:03 ` Christoph Hellwig
2009-09-01 18:08 ` Christoph Hellwig
2009-09-10 16:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090910160819.GA21031@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox