From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_fsr: fix test for short write
Date: Tue, 22 Sep 2009 08:03:53 -0400 [thread overview]
Message-ID: <20090922120353.GC8143@infradead.org> (raw)
In-Reply-To: <4AB307AD.9010904@sandeen.net>
On Thu, Sep 17, 2009 at 11:08:13PM -0500, Eric Sandeen wrote:
> Clang found this one too, as a dead nested assignment.
>
> The point is to see if we write all the bytes; but the initial
> assignment is backwards. It's safe in the end, because if they
> weren't already equal anyway, we'd have exited prior to this, but
> it's worth fixing up for clarity.
>
> Signed-of-by: Eric Sandeen <sandeen@sandeen.net>
Looks good to me,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-09-22 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 4:08 [PATCH] xfs_fsr: fix test for short write Eric Sandeen
2009-09-22 12:03 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090922120353.GC8143@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox