From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfs_repair: fix record_allocation list manipulation
Date: Tue, 22 Sep 2009 16:04:56 -0400 [thread overview]
Message-ID: <20090922200456.GA28826@infradead.org> (raw)
In-Reply-To: <4AB8EB80.80707@sandeen.net>
On Tue, Sep 22, 2009 at 10:21:36AM -0500, Eric Sandeen wrote:
> > After reviewing it again I noticed that it can actually work
>
> the original code can work?
Well, could in theory if fixed as in your patch ;-)
> IF barry's speedups stuff obsoletes this work should I just put it on
> the shelf for now?
No, it doesn't. As I mentioned his original patches contained a fix
like yours, but I left it out because I didn't understand it yet.
I think the patch will cause some minor merge pain as it touches
incore.c which gets more or less fully rewritten as part of the
patch series. I think it's useful enough to be put in, but so are
the other repair patches :)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-09-22 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 3:38 [PATCH] xfs_repair: fix record_allocation list manipulation Eric Sandeen
2009-09-18 4:54 ` Eric Sandeen
2009-09-18 5:19 ` [PATCH] repair: replaced custom block allocation linked lists with list_heads Josef 'Jeff' Sipek
2009-09-25 14:41 ` Eric Sandeen
2009-09-19 14:42 ` [PATCH V2] xfs_repair: fix record_allocation list manipulation Eric Sandeen
2009-09-22 12:02 ` Christoph Hellwig
2009-09-22 15:21 ` Eric Sandeen
2009-09-22 20:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090922200456.GA28826@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox