From: Thomas Neumann <tneumann@users.sourceforge.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@oss.sgi.com
Subject: Re: deadlocks with fallocate
Date: Thu, 15 Oct 2009 07:58:05 +0200 [thread overview]
Message-ID: <200910150758.06003.tneumann@users.sourceforge.net> (raw)
In-Reply-To: <20091014150951.GA13123@infradead.org>
> Can you try if the hack below makes the problem go away?
>
>
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_aops.c 2009-10-14
> 17:06:50.489254023 +0200 +++
> linux-2.6/fs/xfs/linux-2.6/xfs_aops.c 2009-10-14 17:07:54.055006445 +0200
> @@ -278,6 +278,8 @@ xfs_end_bio_unwritten(
> xfs_off_t offset = ioend->io_offset;
> size_t size = ioend->io_size;
>
> + current->flags |= PF_FSTRANS;
> +
> if (likely(!ioend->io_error)) {
> if (!XFS_FORCED_SHUTDOWN(ip->i_mount)) {
> int error;
>
I did some more tests, and indeed the patch makes the deadlock go away. Your
description of it as a hack makes me somewhat concerned about using it
permanently, but hopefully you will find a proper solution ;)
Thanks for looking at this.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-10-15 5:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 6:59 deadlocks with fallocate Thomas Neumann
2009-10-14 15:09 ` Christoph Hellwig
2009-10-14 23:16 ` Thomas Neumann
2009-10-15 5:58 ` Thomas Neumann [this message]
2009-10-15 12:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910150758.06003.tneumann@users.sourceforge.net \
--to=tneumann@users.sourceforge.net \
--cc=hch@infradead.org \
--cc=linux-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox