From: Christoph Hellwig <hch@infradead.org>
To: r-yamauchi@vf.jp.nec.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix xfs_quota remove error
Date: Thu, 22 Oct 2009 04:58:45 -0400 [thread overview]
Message-ID: <20091022085845.GA1423@infradead.org> (raw)
In-Reply-To: <20091022160627r-yamauchi@mail.jp.nec.com>
On Thu, Oct 22, 2009 at 04:06:27PM +0900, r-yamauchi@vf.jp.nec.com wrote:
> Hi,
>
> The xfs_quota returns ENOSYS when remove command is executed.
> My kernel version is 2.6.31 and xfsprogs version is 3.0.3.
> You can reproduce this issue with following steps.
>
> # mount -t xfs -o uquota /dev/sda7 /mnt/mp1
> # xfs_quota -x -c off -c remove
> XFS_QUOTARM: Function not implemented.
>
> The remove command is allowed during quotaoff,
> but xfs_xstate() checks whether quota is running,
> so it leads to ENOSYS.
>
> To solve this problem, add conditional statement
> that op is not X_QUOTARM with running check.
Thanks you, the patch looks correct. I will write an xfstests testcase
based on your above report to make sure we can check for this regression
in the future.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-10-22 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 7:06 [PATCH] xfs: fix xfs_quota remove error r-yamauchi
2009-10-22 8:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022085845.GA1423@infradead.org \
--to=hch@infradead.org \
--cc=r-yamauchi@vf.jp.nec.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox