From: Christoph Hellwig <hch@infradead.org>
To: Nathan Scott <nscott@aconex.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: simplify and unify source package generation
Date: Sun, 25 Oct 2009 03:47:15 -0400 [thread overview]
Message-ID: <20091025074715.GC9482@infradead.org> (raw)
In-Reply-To: <1205635767.11581255391391231.JavaMail.root@mail-au.aconex.com>
On Tue, Oct 13, 2009 at 10:49:51AM +1100, Nathan Scott wrote:
> >From looking through the patch it seems OK to me. I haven't had a chance
> to test it out yet, though - but from just eyeballing it, and if noone
> pipes up complaining about the auto-rpm-build removal (I don't expect
> they will, at this stage of xfsprogs life) it all looks good and correct.
Thanks. Does this count as a reviewed-by?
Btw, one other thing I'm pondering is removing the automatic call to
./configure from make if it's not configured yet. It causes lots of
pain for the toplevel makefile and the makefile snipplets in include/.
We'd have to replace the .deb building makefile snipplet with a
build-debs.sh shell script, but that might be cleaner anyway.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-10-25 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 2:45 [PATCH] xfsprogs: simplify and unify source package generation Christoph Hellwig
2009-10-12 23:49 ` Nathan Scott
2009-10-13 0:29 ` Eric Sandeen
2009-10-25 7:47 ` Christoph Hellwig [this message]
2009-10-25 22:36 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091025074715.GC9482@infradead.org \
--to=hch@infradead.org \
--cc=nscott@aconex.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox