From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: fix up have_xlog_assign_lsn config test
Date: Fri, 30 Oct 2009 01:43:00 -0400 [thread overview]
Message-ID: <20091030054300.GA27680@infradead.org> (raw)
In-Reply-To: <4ADE80D1.7080408@sandeen.net>
On Tue, Oct 20, 2009 at 10:32:33PM -0500, Eric Sandeen wrote:
> Without this we weren't building src/loggen
Looks good to me,
Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
>
> diff --git a/aclocal.m4 b/aclocal.m4
> index 8a61e39..6e1e672 100644
> --- a/aclocal.m4
> +++ b/aclocal.m4
> @@ -422,10 +422,10 @@ AC_DEFUN([AC_PACKAGE_WANT_XFS_LIBXFS_H],
> ])
>
> AC_DEFUN([AC_PACKAGE_WANT_XLOG_ASSIGN_LSN],
> - [
> - AC_CHECK_DECL(xlog_assign_lsn,
> + [ AC_CHECK_DECL(xlog_assign_lsn,
> [ have_xlog_assign_lsn=true ], [ have_xlog_assign_lsn=false ],
> [[#include <xfs/libxfs.h>]])
> + AC_SUBST(have_xlog_assign_lsn)
> ])
>
> AC_DEFUN([AC_PACKAGE_NEED_XFS_XQM_H],
> diff --git a/m4/package_xfslibs.m4 b/m4/package_xfslibs.m4
> index 870882f..f5167a2 100644
> --- a/m4/package_xfslibs.m4
> +++ b/m4/package_xfslibs.m4
> @@ -14,11 +14,10 @@ AC_DEFUN([AC_PACKAGE_WANT_LIBXFS_H],
> ])
>
> AC_DEFUN([AC_PACKAGE_WANT_XLOG_ASSIGN_LSN],
> - [
> - AC_CHECK_DECL(xlog_assign_lsn,
> + [ AC_CHECK_DECL(xlog_assign_lsn,
> [ have_xlog_assign_lsn=true ], [ have_xlog_assign_lsn=false ],
> [[#include <xfs/libxfs.h>]])
> - AC_SUBST(have_have_xlog_assign_lsn)
> + AC_SUBST(have_xlog_assign_lsn)
> ])
>
> AC_DEFUN([AC_PACKAGE_NEED_XFS_XQM_H],
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-10-30 5:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 3:32 [PATCH] xfstests: fix up have_xlog_assign_lsn config test Eric Sandeen
2009-10-30 5:43 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091030054300.GA27680@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox