From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: reset the i_iolock lock class in the reclaim path
Date: Tue, 3 Nov 2009 09:55:59 -0500 [thread overview]
Message-ID: <20091103145559.GC32542@infradead.org> (raw)
In-Reply-To: <1AB9A794DBDDF54A8A81BE2296F7BDFE83AE5D@cf--amer001e--3.americas.sgi.com>
On Mon, Nov 02, 2009 at 03:54:02PM -0600, Alex Elder wrote:
> The comment in xfs_fs_clear_inode() is very informative, but
> it may be emphasizing a lot of detail that doesn't really
> help the reader at this spot in the code. What about wording
> something more like this:
> The iolock is used by the file system to coordinate
> reads, writes, and block truncates. Up to this point
> the lock protected concurrent accesses by users of
> the inode. But from here forward we're doing some final
> processing of the inode because we're done with it,
> and although we reuse the iolock for protection it is
> really a distinct lock class (in the lockdep sense) from
> before. To keep lockdep happy (and basically indicate
> what we are doing), we explicitly re-init the iolock here.
Fine with me. Do you want a respin or will you fix up the comment on the
fly?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-11-03 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 4:05 [PATCH] xfs: reset the i_iolock lock class in the reclaim path Christoph Hellwig
2009-10-30 8:55 ` Christoph Hellwig
2009-11-02 21:54 ` Alex Elder
2009-11-03 14:55 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103145559.GC32542@infradead.org \
--to=hch@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox