From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: improve metadata I/O merging in the elevator
Date: Mon, 16 Nov 2009 14:50:19 +1100 [thread overview]
Message-ID: <20091116035019.GI9467@discord.disaster> (raw)
In-Reply-To: <20091112190930.GB32110@infradead.org>
On Thu, Nov 12, 2009 at 02:09:31PM -0500, Christoph Hellwig wrote:
> I had the patch below from Dave in my queue for a while, but previously
> couldn't really reproduce his numbers. After some discussions of the
> bio types I've reteseted it again and can see constant improvements when
> using cfq on my large array box with it (5-10% for the sequential create
> workloads), but still nothing on deadline. Given that people also want
> it for better marking in blktrace it might be time to put it in.
>
> Comments?
Definitely should be done, but....
It looks like the patch you posted isn't quite doing what was
intended - async write buffers are being classified as WRITE, not
WRITE_META. That means we get more write combining in the elevator
(performance increase) like with WRITE_META, but don't get the
faster dispatch (latency reduction) by using the META queue to keep
the metadata writeback separate from the bulk data writeback.
That may be why deadline is not showing any improvement...
FWIW, the original patch here:
http://oss.sgi.com/archives/xfs/2008-01/msg00630.html
uses WRITE_META, but it looks like you've taken bits of this
patch:
http://oss.sgi.com/archives/xfs/2008-01/msg00653.html
and added the log buffer marking to this patch and accidentally
dropped the WRITE_META marking. i.e. this:
> + } else if (bp->b_flags & _XBF_RUN_QUEUES) {
> + ASSERT(!(bp->b_flags & XBF_READ_AHEAD));
> + bp->b_flags &= ~_XBF_RUN_QUEUES;
> + rw = (bp->b_flags & XBF_WRITE) ? WRITE : READ_META;
I think should be:
+ rw = (bp->b_flags & XBF_WRITE) ? WRITE_META : READ_META;
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-11-16 3:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 19:09 [PATCH] xfs: improve metadata I/O merging in the elevator Christoph Hellwig
2009-11-16 3:50 ` Dave Chinner [this message]
2009-11-16 11:05 ` Christoph Hellwig
2009-11-24 18:03 ` [PATCH v2] " Christoph Hellwig
2009-12-15 20:12 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116035019.GI9467@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox